Re: citex regression fails with de.UTF8 locale

From: "David E(dot) Wheeler" <david(at)kineticode(dot)com>
To: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
Cc: Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter_e(at)gmx(dot)net>
Subject: Re: citex regression fails with de.UTF8 locale
Date: 2009-04-23 16:29:06
Message-ID: 90268D36-A5AD-4038-90C5-01A430ADC0C3@kineticode.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Apr 23, 2009, at 12:22 AM, Heikki Linnakangas wrote:

> Zdenek Kotala wrote:
>> It seems to me that citex_cmp can return any integer value. It
>> depends
>> what wcscoll() returns. I think it should be changed to:
>> SELECT citext_cmp('B'::citext, 'a'::citext) > 0 AS one;
>
> The comment in varstr_cmp() claims that it returns -1, 0 or 1.
> That's not accurate then.
>
> Comment and test case fixed. I considered changing varstr_cmp to
> really return -1, 0 or 1, but I didn't because the behavior has been
> unchanged for ages and all the callers are happy with it. That's a
> heavily called function so any extra cycles there could make a
> difference.

Thanks, I also changed it in my version for 8.3.

https://svn.kineticode.com/citext/trunk/

Best,

David

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2009-04-23 17:46:41 Why do we let CREATE DATABASE reassign encoding?
Previous Message Tom Lane 2009-04-23 16:04:04 Re: Copyright waiver from Helios (fix for non-BSD copyright)