| From: | Teodor Sigaev <teodor(at)sigaev(dot)ru> |
|---|---|
| To: | Alexander Korotkov <aekorotkov(at)gmail(dot)com>, Jim Nasby <jim(dot)nasby(at)openscg(dot)com> |
| Cc: | David Steele <david(at)pgmasters(dot)net>, Andres Freund <andres(at)anarazel(dot)de>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)2ndquadrant(dot)com> |
| Subject: | Re: PinBuffer() no longer makes use of strategy |
| Date: | 2017-03-20 15:09:37 |
| Message-ID: | 8fd788ef-8e69-e12e-2262-e5cd9d2a5078@sigaev.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> if (buf->usage_count < BM_MAX_USAGE_COUNT)
> if (BUF_STATE_GET_USAGECOUNT(buf_state) != BM_MAX_USAGE_COUNT)
>
> being prone to paranoia, I prefer the first, but I've seen both styles in
> the code so I don't know if it's worth futzing with.
>
>
> Ok, let's be paranoic and do this same way as before. Revised patch is attached.
I see the change was done in 9.6 release cycle in commit
48354581a49c30f5757c203415aa8412d85b0f70 at April, 10. Does it mean the fix
should be backpatched too?
--
Teodor Sigaev E-mail: teodor(at)sigaev(dot)ru
WWW: http://www.sigaev.ru/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavan Deolasee | 2017-03-20 15:09:43 | Re: Patch: Write Amplification Reduction Method (WARM) |
| Previous Message | Stephen Frost | 2017-03-20 15:06:09 | Re: Re: [COMMITTERS] pgsql: Improve pg_dump regression tests and code coverage |