| From: | Jan Nidzwetzki <jan(at)planetscale(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
| Cc: | Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com>, ♂π≌26218 <1991230470(at)qq(dot)com>, pgsql-bugs <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: START_REPLICATION silently truncates an overlong LSN component |
| Date: | 2026-10-28 11:33:35 |
| Message-ID: | 8f98c2af-ca6d-4cc5-9c88-5cb1505a3db7@planetscale.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Hi Kuroda-san, Fujii-san,
On 28.10.26 11:50, Fujii Masao wrote:
> On Wed, Oct 28, 2026 at 12:18 PM Hayato Kuroda (Fujitsu)
> <kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
>> Hmm. But 5ffb8c74 also did not have any tests and the error "syntax error in history file:"
>> is nor verified, right? I still feel we can follow the manner.
>
> I'm not convinced that 0002 and 0003 are necessary. OTOH, there seems to be
> general agreement on 0001, so barring any objections, I'll commit that patch.
No objections from my side.
Kuroda-san, you are right about CppAsString2(). I missed that the value
is stringified for scanf. Thanks for checking. So, I am fine with 0001.
The static assert and the test can be left out.
Best regards
Jan
--
Jan Nidzwetzki
PlanetScale Postgres Core Team
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Pang | 2026-10-28 11:47:42 | pg_rewind and hint bits leads to visibility corruption |
| Previous Message | Kirill Reshke | 2026-10-28 10:56:31 | Re: pg_trgm: GiST index scan misses rows at the default word_similarity_threshold |