From: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, pgbf(at)twiska(dot)com |
Subject: | Re: XversionUpgrade tests broken by postfix operator removal |
Date: | 2020-09-20 00:31:25 |
Message-ID: | 8f55c45d-cbdb-4339-498d-fd9e8e622859@2ndQuadrant.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 9/19/20 12:21 PM, Tom Lane wrote:
> Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> writes:
>> Here's how cross version upgrade testing works. It uses a cached version of the binaries and data directory. The cache is only refreshed if there's a buildfarm run on that branch. If not, the cached version will just sit there till kingdom come. So all this should normally need for the non-live branches is a one-off adjustment in the cached version of the regression database along the lines I have indicated. My cached versions of 9.2 and 9.3 are two years old.
> Hmm, okay, so patching this on gitmaster wouldn't help anyway.
>
>> But another alternative would be to have the buildfarm module run (on
>> versions older than 9.5):
>> drop operator @#@ (NONE, bigint);
>> CREATE OPERATOR @#@ (
>> PROCEDURE = factorial,
>> RIGHTARG = bigint
>> );
>> On reflection I think that's probably the simplest solution. It will avoid any surprises if the cached version is rebuilt, and at the same time preserve testing the prefix operator.
> Works for me.
>
>
OK, I rolled back the changes I made in the legacy branch databases, and
this fix worked.
For reference, here is the complete hotfix.
cheers
andrew
--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Attachment | Content-Type | Size |
---|---|---|
bf-xversion-operator-hotfix.patch | text/x-patch | 1.4 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Thomas Munro | 2020-09-20 00:40:14 | Re: Handing off SLRU fsyncs to the checkpointer |
Previous Message | Corey Huinker | 2020-09-19 23:25:37 | Re: Feature proposal for psql |