Re: Nicer error when connecting to standby with hot_standby=off

From: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, James Coleman <jtc331(at)gmail(dot)com>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, David Steele <david(at)pgmasters(dot)net>, David Zhang <david(dot)zhang(at)highgo(dot)ca>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Nicer error when connecting to standby with hot_standby=off
Date: 2021-03-23 19:56:36
Message-ID: 8e963bb0-242a-673c-772f-37fa288e69cc@oss.nttdata.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2021/03/24 1:20, Alvaro Herrera wrote:
> On 2021-Mar-23, James Coleman wrote:
>
>> On Tue, Mar 23, 2021 at 1:46 AM Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
>
>>> Therefore for now what we've not reached the consensus is what message
>>> should be logged at PM_STARTUP. I'm thinking it's better to log
>>> "the database system is starting up" in that case because of the reasons
>>> that I explained upthread.
>
>> I understand your point now, and I agree, that makes sense.
>
> Please note that PM_STARTUP mode is very very short-lived. It only
> starts happening when postmaster launches the startup process, and
> before the startup process begins WAL replay (as changed by
> sigusr1_handler in postmaster.c). Once WAL replay begins, the PM status
> changes to PM_RECOVERY.

True if archive recovery or standby server. But during crash recovery
postmaster sits in PM_STARTUP mode. So I guess that we still see
the log messages for PM_STARTUP lots of times.

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jan Wieck 2021-03-23 19:59:48 Re: pg_upgrade failing for 200+ million Large Objects
Previous Message Peter Geoghegan 2021-03-23 19:53:35 Re: pg_amcheck contrib application