Re: Ltree syntax improvement

From: Nikita Glukhov <n(dot)gluhov(at)postgrespro(dot)ru>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Cc: Dmitry Belyavsky <beldmit(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Nikolay Shaplov <dhyan(at)nataraj(dot)su>
Subject: Re: Ltree syntax improvement
Date: 2020-04-03 23:26:06
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 02.04.2020 19:16, Tom Lane wrote:

> Nikita Glukhov <n(dot)gluhov(at)postgrespro(dot)ru> writes:
>> Rebased patch attached.
> Thanks for rebasing! The cfbot's not very happy though:
> 4842ltxtquery_io.c: In function ‘makepol’:
> 4843ltxtquery_io.c:188:13: error: ‘escaped’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
> 4844 if (lenval - escaped <= 0)
> 4845 ^
> 4846ltxtquery_io.c:230:6: note: ‘escaped’ was declared here
> 4847 int escaped;
> 4848 ^
> 4849cc1: all warnings being treated as errors
> regards, tom lane

Fixed patch attached.

Nikita Glukhov
Postgres Professional:
The Russian Postgres Company

Attachment Content-Type Size
0001-Ltree-syntax-improvements-20200403.patch text/x-patch 67.7 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2020-04-03 23:50:13 Re: backup manifests and contemporaneous buildfarm failures
Previous Message Peter Geoghegan 2020-04-03 23:25:55 Re: vacuum_defer_cleanup_age inconsistently applied on replicas