| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "Drouvot, Bertrand" <bdrouvot(at)amazon(dot)com> |
| Subject: | Re: Generating code for query jumbling through gen_node_support.pl |
| Date: | 2023-01-30 10:46:06 |
| Message-ID: | 8e55839d-4894-fb5e-fc53-bd9dfb016c3a@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 27.01.23 04:07, Michael Paquier wrote:
> On Thu, Jan 26, 2023 at 09:39:05AM +0100, Peter Eisentraut wrote:
>> There are a couple of repetitive comments, like "typmod and collation
>> information are irrelevant for the query jumbling". This applies to all
>> nodes, so we don't need to repeat it for a number of nodes (and then not
>> mention it for other nodes). Maybe there should be a central place
>> somewhere that describes "these kinds of fields should normally be ignored".
>
> The place that would make the most sense to me to centralize this
> knowlegde is nodes.h itself, because that's where the node attributes
> are defined?
Either that or src/backend/nodes/README.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2023-01-30 10:48:45 | Re: Generating code for query jumbling through gen_node_support.pl |
| Previous Message | Peter Eisentraut | 2023-01-30 10:42:12 | Re: [DOCS] Stats views and functions not in order? |