| From: | Dean Rasheed <dean(dot)a(dot)rasheed(at)googlemail(dot)com> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Memory leak in deferrable index constraints |
| Date: | 2010-01-31 14:45:41 |
| Message-ID: | 8e2dbb701001310645k28ae8fa3rbc130a83184a5e10@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Oops, my fault. The list returned by ExecInsertIndexTuples() needs to be
freed otherwise lots of lists (one per row) will build up and not be freed
until the end of the query. This actually accounts for even more memory
than the after-trigger event queue. Patch attached.
Of course the after-trigger queue still uses a lot of memory for large
updates (I was working on a patch for that but ran out of time before
this commitfest started). This fix at least brings deferred index
constraints into line with FK constraints, in terms of memory usage.
Regards,
Dean
| Attachment | Content-Type | Size |
|---|---|---|
| memory_leak.patch | application/octet-stream | 1.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2010-01-31 16:03:01 | Re: Memory leak in deferrable index constraints |
| Previous Message | Matteo Beccati | 2010-01-31 14:09:17 | Re: mailing list archiver chewing patches |