From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
---|---|
To: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Darafei Komяpa Praliaskouski <me(at)komzpa(dot)net>, Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Yet another fast GiST build |
Date: | 2020-11-02 14:45:56 |
Message-ID: | 8da4bfd7-758c-4a20-7760-2841c0725ff8@iki.fi |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 30/10/2020 20:20, Andrey Borodin wrote:
>> 27 окт. 2020 г., в 16:43, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> написал(а):
>>> static bool
>>> gbt_inet_abbrev_abort(int memtupcount, SortSupport ssup)
>>> {
>>> #if SIZEOF_DATUM == 8
>>> return false;
>>> #else
>>> return true;
>>> #endif
>>> }
>>
>> Better to not set the 'abbrev_converter' function in the first place. Or would it be better to cast the float8 to float4 if SIZEOF_DATUM == 4?
> Ok, now for 4 bytes Datum we do return (Datum) Float4GetDatum((float) z);
A few quick comments:
* Currently with float8, you immediately abort abbreviation if
SIZEOF_DATUM == 4. Like in the 'inet' above, you could convert the
float8 to float4 instead.
* Some of the ALTER OPERATOR FAMILY commands in btree_gist--1.6--1.7.sql
are copy-pasted wrong. Here's one example:
ALTER OPERATOR FAMILY gist_timestamptz_ops USING gist ADD
FUNCTION 11 (text, text) gbt_text_sortsupport;
* It's easy to confuse the new comparison functions with the existing
comparisons used by the picksplit functions. Some comments and/or naming
changes would be good to clarify how they're different.
* It would be straightforward to have abbreviated functions for macaddr
and macaddr8 too.
> How do you think, should this patch and patch with pageinspect GiST functions be registered on commitfest?
Yeah, that'd be good.
- Heikki
From | Date | Subject | |
---|---|---|---|
Next Message | Masahiko Sawada | 2020-11-02 14:49:16 | Re: Fix a typo in verify_heapam.c |
Previous Message | Tomas Vondra | 2020-11-02 14:44:53 | Re: COPY FREEZE and setting PD_ALL_VISIBLE/visibility map bits |