| From: | Jan Wieck <jan(at)wi3ck(dot)info> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Zhihong Yu <zyu(at)yugabyte(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Magnus Hagander <magnus(at)hagander(dot)net>, Robins Tharakan <tharakan(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_upgrade failing for 200+ million Large Objects |
| Date: | 2021-03-23 17:25:15 |
| Message-ID: | 8d8d3961-8e8b-3dbe-f911-6f418c5fb1d3@wi3ck.info |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 3/23/21 10:56 AM, Bruce Momjian wrote:
> On Tue, Mar 23, 2021 at 08:51:32AM -0400, Jan Wieck wrote:
>> On 3/22/21 7:18 PM, Jan Wieck wrote:
>> > On 3/22/21 5:36 PM, Zhihong Yu wrote:
>> > > Hi,
>> > >
>> > > w.r.t. pg_upgrade_improvements.v2.diff.
>> > >
>> > > + blobBatchCount = 0;
>> > > + blobInXact = false;
>> > >
>> > > The count and bool flag are always reset in tandem. It seems
>> > > variable blobInXact is not needed.
>> >
>> > You are right. I will fix that.
>>
>> New patch v3 attached.
>
> Would it be better to allow pg_upgrade to pass arbitrary arguments to
> pg_restore, instead of just these specific ones?
>
That would mean arbitrary parameters to pg_dump as well as pg_restore.
But yes, that would probably be better in the long run.
Any suggestion as to how that would actually look like? Unfortunately
pg_restore has -[dDoOr] already used, so it doesn't look like there will
be any naturally intelligible short options for that.
Regards, Jan
--
Jan Wieck
Principle Database Engineer
Amazon Web Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Drouvot, Bertrand | 2021-03-23 17:31:48 | Re: Minimal logical decoding on standbys |
| Previous Message | Andres Freund | 2021-03-23 17:24:45 | Re: Replication slot stats misgivings |