Re: pgsql: Add the MODE option to the WAIT FOR LSN command

On 05.01.26 18:56, Alexander Korotkov wrote:
> Add the MODE option to the WAIT FOR LSN command

> Details
> -------
> https://git.postgresql.org/pg/commitdiff/49a181b5d634340fcfb7c762c387c03f6405367e
>
> Modified Files
> --------------
> doc/src/sgml/ref/wait_for.sgml | 213 +++++++++++++----
> src/backend/access/transam/xlog.c | 22 +-
> src/backend/commands/wait.c | 174 ++++++++++++--
> src/backend/replication/walreceiver.c | 18 ++
> src/test/recovery/t/049_wait_for_lsn.pl | 411 +++++++++++++++++++++++++++++---
> 5 files changed, 741 insertions(+), 97 deletions(-)

This patch adds several instances in src/backend/commands/wait.c where
an elog(ERROR) is followed immediately by pg_unreachable(). I think
this is redundant. I think this pattern has been used historically in
functions that return non-void where the elog(ERROR) is the last call,
to avoid warnings about a missing return. But in this case, the
function returns void. Check please if this is really necessary or just
copy-and-pasted.