Re: [Proposal] Fully WAL logged CREATE DATABASE - No Checkpoints

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [Proposal] Fully WAL logged CREATE DATABASE - No Checkpoints
Date: 2022-02-11 17:11:40
Message-ID: 8c643fe4-3ca4-adb4-07cb-3b79988ea84b@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 2/10/22 07:32, Dilip Kumar wrote:
> On Wed, Feb 9, 2022 at 9:31 PM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> On Wed, Feb 9, 2022 at 10:59 AM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
>>> On Wed, Feb 9, 2022 at 9:25 PM Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>>>> On 6/16/21 03:52, Dilip Kumar wrote:
>>>>> On Tue, Jun 15, 2021 at 7:01 PM Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>>>>>> Rather than use size, I'd be inclined to say use this if the source
>>>>>> database is marked as a template, and use the copydir approach for
>>>>>> anything that isn't.
>>>>> Yeah, that is possible, on the other thought wouldn't it be good to
>>>>> provide control to the user by providing two different commands, e.g.
>>>>> COPY DATABASE for the existing method (copydir) and CREATE DATABASE
>>>>> for the new method (fully wal logged)?
>>>> This proposal seems to have gotten lost.
>>> Yeah, I am planning to work on this part so that we can support both methods.
>> But can we pick a different syntax? In my view this should be an
>> option to CREATE DATABASE rather than a whole new command.
> Maybe we can provide something like
>
> CREATE DATABASE..WITH WAL_LOG=true/false ? OR
> CREATE DATABASE..WITH WAL_LOG_DATA_PAGE=true/false ? OR
> CREATE DATABASE..WITH CHECKPOINT=true/false ? OR
>
> And then we can explain in documentation about these options? I think
> default should be new method?
>
>

The last one at least has the advantage that it doesn't invent yet
another keyword.

I can live with the new method being the default. I'm sure it would be
highlighted in the release notes too.

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Justin Pryzby 2022-02-11 17:29:29 Re: pgsql: Add TAP test to automate the equivalent of check_guc
Previous Message Tomas Vondra 2022-02-11 17:06:10 Re: the build farm is ok, but not the hippopotamus (or the jay)