Re: testing dist tarballs

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Christoph Berg <myon(at)debian(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: testing dist tarballs
Date: 2023-05-31 10:52:03
Message-ID: 8c1ff0a4-0295-cb60-191e-7ea584eb405b@eisentraut.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 27.05.23 14:47, Andres Freund wrote:
>>> Separately, it's somewhat confusing that we include errcodes.h etc in
>>> src/backend/utils, rather than its final location, in src/include/utils. It
>>> works, even without perl, because copying the file doesn't require perl, it's
>>> just generating it...
>>
>> The "copying" is actually a symlink, right? I don't think we want to ship
>> symlinks in the tarball?
>
> Fair point - still seems we should just create the files in the right
> directory instead of doing it in the wrong place and then creating symlinks to
> make them accessible...

Right. I think the reason this was set up this way is that with make it
is generally dubious to create target files outside of the current
directory.

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2023-05-31 11:01:46 pgsql: doc: PG 16 relnotes, move memory item and reword OUTER item
Previous Message Bruce Momjian 2023-05-30 23:32:39 pgsql: doc: PG 16 relnotes, add memory overhead reduction item

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2023-05-31 10:55:00 Re: Why does pg_bsd_indent need to be installed?
Previous Message Drouvot, Bertrand 2023-05-31 10:14:53 Re: Test slots invalidations in 035_standby_logical_decoding.pl only if dead rows are removed