| From: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
|---|---|
| To: | Zhihong Yu <zyu(at)yugabyte(dot)com> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Jaime Casanova <jcasanov(at)systemguards(dot)com(dot)ec>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: extended stats on partitioned tables |
| Date: | 2021-12-12 17:52:00 |
| Message-ID: | 8bd5bb15-906c-6682-0f50-394fbc2a4a15@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 12/12/21 16:37, Zhihong Yu wrote:
>
> Hi,
> For patch 1, minor comment:
>
> + if (planner_rt_fetch(onerel->relid, root)->inh)
>
> Since the rte (RangeTblEntry*) doesn't seem to be used beyond checking
> inh, I think it would be better if the above style of checking is used
> throughout the patch (without introducing rte variable).
>
It's mostly a matter of personal taste, but I always found this style of
condition (i.e. dereferencing a pointer returned by a function) much
less readable. It's hard to parse what exactly is happening, what struct
type are we dealing with, etc. YMMV but the separate variable makes it
much clearer for me. And I'd expect the compilers to produce pretty much
the same code too for those cases.
regards
--
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Justin Pryzby | 2021-12-12 17:52:56 | Re: extended stats on partitioned tables |
| Previous Message | Tomas Vondra | 2021-12-12 17:45:43 | Re: extended stats on partitioned tables |