Re: Newline after --progress report

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Newline after --progress report
Date: 2020-08-17 14:20:46
Message-ID: 8b57b3e4-f7a6-8acd-5a79-9129ccae6782@iki.fi
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 17/08/2020 16:59, Tom Lane wrote:
> Heikki Linnakangas <hlinnaka(at)iki(dot)fi> writes:
>> Good point. Pushed a patch along those lines.
>
> Uh ... you patched v12 but not v13?

Darn, I forgot it exists.

> Also, I'd recommend that you NOT do this:
>
> + fprintf(stderr, (!finished && isatty(fileno(stderr))) ? "\r" : "\n");
>
> as it breaks printf format verification in many/most compilers.

Ok. I pushed the same commit to v12 as to other branches now, to keep
them in sync. I'll go fix that as a separate commit. Thanks!

- Heikki

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2020-08-17 14:50:41 Re: One-off failure in "cluster" test
Previous Message Dilip Kumar 2020-08-17 14:18:10 Re: Parallel bitmap index scan