Re: max_slot_wal_keep_size comment in postgresql.conf

On 2020/05/27 15:11, Michael Paquier wrote:
> On Wed, May 27, 2020 at 10:46:27AM +0900, Kyotaro Horiguchi wrote:
>> Agreed. It should be a leftover at the time the unit was changed
>> (before committed) to MB from bytes. The default value makes the
>> confusion worse.
>>
>> Is the following works?
>>
>> #max_slot_wal_keep_size = -1 # in MB; -1 disables
>
> Indeed, better to fix that. The few GUCs using memory units that have
> such a mention in their comments use the actual name of the memory
> unit, and not its abbreviation (see log_temp_files). So it seems more
> logic to me to just use "in megabytes; -1 disables", that would be
> also more consistent with the time-unit-based ones.

+1

#temp_file_limit = -1 # limits per-process temp file space
# in kB, or -1 for no limit

BTW, the abbreviation "in kB" is used in temp_file_limit.

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION