| From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | alvherre(at)alvh(dot)no-ip(dot)org, nagata(at)sraoss(dot)co(dot)jp, ranier(dot)vf(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: corruption of WAL page header is never reported |
| Date: | 2021-10-05 15:18:27 |
| Message-ID: | 8ad26151-78af-665f-292d-1a5c4d9bee4c@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021/10/05 10:58, Kyotaro Horiguchi wrote:
> At Tue, 5 Oct 2021 00:59:46 +0900, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote in
>> I think that it's better to comment why "retry" is not necessary
>> when not in standby mode.
>>
>> -------------------
>> When not in standby mode, an invalid page header should cause recovery
>> to end, not retry reading the page, so we don't need to validate the
>> page
>> header here for the retry. Instead, ReadPageInternal() is responsible
>> for
>> the validation.
>
> LGTM.
Thanks for the review! I updated the comment and pushed the patch.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2021-10-05 15:34:11 | Re: using an end-of-recovery record in all cases |
| Previous Message | Greg Stark | 2021-10-05 15:11:22 | Re: RfC entries in CF 2021-09 |