| From: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jim Nasby <jim(dot)nasby(at)openscg(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: [HACKERS] Re: Improve OR conditions on joined columns (common star schema problem) |
| Date: | 2018-02-02 12:41:37 |
| Message-ID: | 8accc0ed-a86a-4b03-46b1-af1216b37ecd@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 01/04/2018 11:50 PM, Tom Lane wrote:
> I wrote:
>> Jim Nasby <jim(dot)nasby(at)openscg(dot)com> writes:
>>> I've verified that the patch still applies and make check-world is clean.
>
>> Not any more :-(. Here's a v3 rebased over HEAD. No substantive
>> change from v2.
>
> Again rebased up to HEAD; still no substantive changes.
>
ISTM this patch got somewhat stuck as we're not quite sure the
transformation is correct in all cases. Is my impression correct? If
yes, how to we convince ourselves? Would some sort of automated testing
(generating data and queries) help? I'm willing to spend some cycles on
that, if considered helpful.
regards
--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeevan Chalke | 2018-02-02 13:25:37 | Re: [HACKERS] Partition-wise aggregation/grouping |
| Previous Message | Andrey Borodin | 2018-02-02 12:22:07 | Re: [HACKERS] Can ICU be used for a database's default sort order? |