Re: perlcritic: prohibit map and grep in void conext

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: perlcritic: prohibit map and grep in void conext
Date: 2021-07-28 11:10:29
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 7/27/21 12:06 PM, Dagfinn Ilmari Mannsåker wrote:
> Hi hackers,
> In the patches for improving the MSVC build process, I noticed a use of
> `map` in void context. This is considered bad form, and has a
> perlcritic policy forbidding it:
> Attached is a patch that increases severity of that and the
> corresponding `grep` policy to 5 to enable it in our perlcritic policy,
> and fixes the one use that had already snuck in.

Personally I'm OK with it, but previous attempts to enforce perlcritic
policies have met with a less than warm reception, and we had to back
off. Maybe this one will fare better.

I keep the buildfarm code perlcritic compliant down to severity 3 with a
handful of exceptions.



Andrew Dunstan

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2021-07-28 11:20:43 Re: Out-of-memory error reports in libpq
Previous Message Amul Sul 2021-07-28 11:07:01 Re: [Patch] ALTER SYSTEM READ ONLY