Re: Re: Reporting script runtimes in pg_regress

From: David Steele <david(at)pgmasters(dot)net>
To: Christoph Berg <myon(at)debian(dot)org>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Daniel Gustafsson <daniel(at)yesql(dot)se>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Re: Reporting script runtimes in pg_regress
Date: 2019-03-20 10:15:15
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hi Christophe,

On 3/8/19 5:12 PM, Alvaro Herrera wrote:
> On 2019-Mar-08, Christoph Berg wrote:
>> Re: Peter Eisentraut 2019-03-08 <3eb194cf-b878-1f63-8623-6d6add0ed0b7(at)2ndquadrant(dot)com>
>>> On 2019-02-21 10:37, Christoph Berg wrote:
>>>> diff --git a/src/test/regress/pg_regress.c b/src/test/regress/pg_regress.c
>>>> index a18a6f6c45..8080626e94 100644
>>>> --- a/src/test/regress/pg_regress.c
>>>> +++ b/src/test/regress/pg_regress.c
>>>> @@ -1794,12 +1794,14 @@ run_schedule(const char *schedule, test_function tfunc)
>>>> else
>>>> {
>>>> status(_("FAILED"));
>>>> + status(" "); /* align with failed (ignored) */
>>>> fail_count++;
>>>> }
>>> So an issue here is that in theory "FAILED" etc. are marked for
>>> translation but your spacers do not take that into account. Personally,
>>> I have no ambition to translate pg_regress, so we could remove all that.
>>> But it should be done consistently in either case.
>> Oh, right. So the way to go would be to use _("FAILED "), and
>> ask translators to use the same length.
> Note there's no translation for pg_regress. All these _() markers are
> currently dead code. It seems hard to become motivated to translate
> that kind of program. I don't think it has much value, myself.

This patch has been "Waiting on Author" since March 8th. Do you know
when you'll have a new version ready?


In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message David Steele 2019-03-20 10:30:53 Re: Re: COPY FREEZE and setting PD_ALL_VISIBLE/visibility map bits
Previous Message Andreas Karlsson 2019-03-20 10:05:53 Re: PostgreSQL pollutes the file system