Re: path toward faster partition pruning

From: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
To: Rajkumar Raghuwanshi <rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com>
Cc: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: path toward faster partition pruning
Date: 2017-10-23 07:42:44
Message-ID: 8a7bffb8-034d-bbe0-9ad5-066dbf726ef8@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

Thanks Rajkumar.

On 2017/10/23 15:58, Rajkumar Raghuwanshi wrote:
> I have tried to apply attached patch. patch applied cleanly on commit id -
> bf54c0f05c0a58db17627724a83e1b6d4ec2712c
> but make failed with below error.
>
> ./../../../src/include/nodes/relation.h:2126: error: redefinition of
> typedef ‘AppendRelInfo’
> ../../../../src/include/nodes/relation.h:584: note: previous declaration of
> ‘AppendRelInfo’ was here
> make[4]: *** [gistbuild.o] Error 1

The compiler I have here (gcc (GCC) 6.2.0) didn't complain like that for
this typedef redefinition introduced by the 0002 patch, but it seems that
it's not needed anyway, so got rid of that line in the attached updated patch.

Fixed one more useless diff in 0002, but no changes in any other patch.

Thanks,
Amit

Attachment Content-Type Size
0001-Add-new-tests-for-partition-pruning-v2.patch text/plain 35.4 KB
0002-Planner-side-changes-for-partition-pruning-v2.patch text/plain 41.0 KB
0003-Implement-get_partitions_from_clauses-v2.patch text/plain 31.1 KB
0004-Some-interface-changes-for-partition_bound_-cmp-bsea-v2.patch text/plain 10.1 KB
0005-Implement-get_partitions_for_keys-v2.patch text/plain 19.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tsunakawa, Takayuki 2017-10-23 08:01:04 [bug fix] ECPG: fails to recognize embedded parameters
Previous Message Craig Ringer 2017-10-23 07:07:31 Re: How to determine that a TransactionId is really aborted?