Re: [PATCH] pgarchives: Bugfix: missing ids in pglister_sync

Hello,

This patch was never merge into master, the issue still exists. I think it's been forgotten.
Can it be merged now?

On 30/01/2022 13:32, Magnus Hagander wrote:
> On Fri, Jan 28, 2022 at 6:52 PM Célestin Matte <celestin(dot)matte(at)cmatte(dot)me> wrote:
>>
>> groupid and listid are not explicitly set in pglister_sync's queries, which
>> causes the script to fail as these fields are NOT NULL and postgresql default
>> configuration does not auto-fill id fields.
>>
>> This patch sets them explicitly by reusing the ones obtained from pglister.
>
> These fields are supposed to be serial fields, not pure integers, I
> think. This feels like some very old legacy that hasn't been properly
> fixed.
>
> I think the attached patch is more correct (I've backpatched it into
> the 0001 migration because making it a separate migration makes it
> somewhat destructive -- it's easier to just change it manually on
> existing installs if you have one)
>

--
Célestin Matte