Perl coding style in postgresql

From: Laurent Laborde <kerdezixe(at)gmail(dot)com>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Perl coding style in postgresql
Date: 2009-04-30 10:28:21
Message-ID: 8a1bfe660904300328o17f6e280md17826056135218d@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Friendly greetings (again) !

I'm planning to patch all perl file in the postgresql source tree.
But i can't find any rules other than : set tabstop=4 shiftwidth=4 noexpandtab

It could be nice to define the perl coding style of postgresql
somewhere on a wiki.

Here is a few questions :
- What is the oldest perl version that we should support ?
- Do we use the sames rules for "tools" and "contribs" (eg : use strict) ?
- is there any obvious rules other than "use strict" ?
- Should we support Win32 platform in perl tools use by developpers
(eg : check_keywords.pl) ? (that include the "\" vs "/" problem in
file path)
- What about dependencies of external perl modules ?
- I'm used to heavily comment my code... should i do that here too ?

it's hard to define "coding style" when talking about perl :)
I will happily patch all perl files ( according to
http://wiki.postgresql.org/wiki/Submitting_a_Patch ) once the most
basic rule are defined :)

*hugs*

--
Laurent Laborde
Sysadmin at jfg://networks
http://www.over-blog.com/

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2009-04-30 10:30:02 Re: Keyword list sanity check
Previous Message Heikki Linnakangas 2009-04-30 10:26:54 Re: Keyword list sanity check