| From: | "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Dilip Kumar <dilipbalaut(at)gmail(dot)com>, tender wang <tndrwang(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
| Subject: | Re: SLRU optimization - configurable buffer pool and partitioning the SLRU lock |
| Date: | 2024-02-27 16:17:11 |
| Message-ID: | 8E9F1FB8-3F89-4114-9732-42057C02112B@yandex-team.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 27 Feb 2024, at 21:03, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
>
> On 2024-Feb-27, Dilip Kumar wrote:
>
>>> static const char *const slru_names[] = {
>>> "commit_timestamp",
>>> "multixact_members",
>>> "multixact_offsets",
>>> "notify",
>>> "serializable",
>>> "subtransaction",
>>> "transaction",
>>> "other" /* has to be last
>>> */
>>> };
>
> Here's a patch for the renaming part.
Sorry for the late reply, I have one nit. Are you sure that multixact_members and multixact_offsets are plural, while transaction and commit_timestamp are singular?
Maybe multixact_members and multixact_offset? Because there are many members and one offset for a givent multixact? Users certainly do not care, thought...
Best regards, Andrey Borodin.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2024-02-27 16:26:07 | Re: SLRU optimization - configurable buffer pool and partitioning the SLRU lock |
| Previous Message | Jelte Fennema-Nio | 2024-02-27 16:06:47 | Re: Improve readability by using designated initializers when possible |