From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | Julien Rouhaud <rjuju123(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Superfluous libpq-be.h include in GSSAPI code |
Date: | 2019-07-01 08:29:17 |
Message-ID: | 8E44E8B1-A01E-46A2-9E96-6B95B3333C54@yesql.se |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> On 29 Jun 2019, at 04:23, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Fri, Jun 28, 2019 at 08:47:33PM +0200, Julien Rouhaud wrote:
>> On Fri, Jun 28, 2019 at 4:37 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>>> backend/libpq/be-secure-gssapi.c is including both libpq-be.h and libpq.h,
>>> which makes libpq-be.h superfluous as it gets included via libpq.h. The
>>> attached patch removes the inclusion of libpq-be.h to make be-secure-gssapi.c
>>> behave like other files which need both headers.
>>
>> LGTM.
>
> Thanks, committed. I looked at the area in case but did not notice
> anything else strange.
Thanks!
> (We have in hba.h a kludge with hbaPort to avoid including libpq-be.h,
> I got to wonder if we could do something about that..)
I looked at that one too at the time, but didn’t come up with anything less
kludgy.
cheers ./daniel
From | Date | Subject | |
---|---|---|---|
Next Message | Thomas Munro | 2019-07-01 08:46:09 | Re: POC: Cleaning up orphaned files using undo logs |
Previous Message | Thomas Munro | 2019-07-01 07:53:26 | Re: POC: Cleaning up orphaned files using undo logs |