| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | "Hou, Zhijie" <houzj(dot)fnst(at)cn(dot)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: remove unneeded pstrdup in fetch_table_list |
| Date: | 2021-01-13 13:23:26 |
| Message-ID: | 8DC03276-E3EF-4EF5-B850-B33B9F2F21BA@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 13 Jan 2021, at 14:09, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Wed, Jan 13, 2021 at 2:55 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>>
>>> On 13 Jan 2021, at 07:10, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>>
>>> Your observation seems correct to me, though I have not tried to test
>>> your patch.
>>
>> +1 to apply, this looks correct and passes tests. Scanning around I didn't see
>> any other occurrences of the same pattern.
>
> Thanks. I am thinking to backpatch this even though there is no
> problem reported from any production system. What do you think?
No objections from me.
cheers ./daniel
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexey Kondratov | 2021-01-13 13:39:40 | Re: Allow CLUSTER, VACUUM FULL and REINDEX to change tablespace on the fly |
| Previous Message | Amit Kapila | 2021-01-13 13:09:23 | Re: remove unneeded pstrdup in fetch_table_list |