From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
---|---|
To: | Mikhail Gribkov <youzhick(at)gmail(dot)com> |
Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: GUC for temporarily disabling event triggers |
Date: | 2023-03-06 12:24:56 |
Message-ID: | 8D26ACC2-7669-460D-833A-582EAD6CC09E@yesql.se |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> On 27 Jan 2023, at 15:00, Mikhail Gribkov <youzhick(at)gmail(dot)com> wrote:
> There is a complete framework for disabling various types of the event triggers separately, but, the list of valid GUC values only include 'all' and 'none'. Why not adding support for all the event trigger types separately? Everything is already there in the patch; the only thing needed is expanding couple of enums. It's cheap in terms of code size and even cheaper in terms of performance. And moreover - it would be a good example for anyone adding new trigger types.
I can't exactly recall my reasoning, but I do think you're right that if we're
to have this GUC it should support the types of existing EVTs. The updated v4
implements that as well as a rebase on top of master and fixing a typo
discovered upthread.
--
Daniel Gustafsson
Attachment | Content-Type | Size |
---|---|---|
v4-0001-Add-GUC-for-temporarily-disabling-event-triggers.patch | application/octet-stream | 12.5 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Andrei Zubkov | 2023-03-06 12:50:55 | Re: Normalization of utility queries in pg_stat_statements |
Previous Message | Hayato Kuroda (Fujitsu) | 2023-03-06 11:56:42 | RE: [Proposal] Add foreign-server health checks infrastructure |