Re: PATCH: add "--config-file=" option to pg_rewind

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Gunnar Nick Bluth <gunnar(dot)bluth(at)pro-open(dot)de>
Cc: Alexander Kukushkin <cyberdemn(at)gmail(dot)com>, Aleksander Alekseev <aleksander(at)timescale(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: PATCH: add "--config-file=" option to pg_rewind
Date: 2022-02-24 13:46:49
Message-ID: 8D17FABD-BEDA-4970-B43D-98D33E4C6C02@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 24 Feb 2022, at 14:43, Gunnar Nick Bluth <gunnar(dot)bluth(at)pro-open(dot)de> wrote:

> That looks just as good to me, and it already has tests, so I'll happily step down!

Actually, I think this looks like a saner approach. Putting a config setting
in two place (postgresql.conf and on the commandline for pg_rewind) is a recipe
for them diverging.

--
Daniel Gustafsson https://vmware.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Aleksander Alekseev 2022-02-24 13:47:25 create_index test fails when synchronous_commit = off @ master
Previous Message Daniel Gustafsson 2022-02-24 13:44:05 Re: Typo in pgbench messages.