From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
---|---|
To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
Cc: | Noah Misch <noah(at)leadboat(dot)com>, John Naylor <john(dot)naylor(at)enterprisedb(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Ian Lawrence Barwick <barwick(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Anastasia Lubennikova <lubennikovaav(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Peter Geoghegan <pg(at)bowt(dot)ie> |
Subject: | Re: Testing autovacuum wraparound (including failsafe) |
Date: | 2023-09-29 10:17:04 |
Message-ID: | 8CD90024-D9FB-4B0D-A7E3-EFFD024CB106@yesql.se |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> On 27 Sep 2023, at 14:39, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> I've attached new version patches. 0001 patch adds an option to
> background_psql to specify the timeout seconds, and 0002 patch is the
> main regression test patch.
-=item PostgreSQL::Test::BackgroundPsql->new(interactive, @params)
+=item PostgreSQL::Test::BackgroundPsql->new(interactive, @params, timeout)
Looking at this I notice that I made a typo in 664d757531e, the =item line
should have "@psql_params" and not "@params". Perhaps you can fix that minor
thing while in there?
+ $timeout = $params{timeout} if defined $params{timeout};
I think this should be documented in the background_psql POD docs.
+ Not enabled by default it is resource intensive.
This sentence is missing a "because", should read: "..by default *because* it
is.."
+# Bump the query timeout to avoid false negatives on slow test systems.
+my $psql_timeout_secs = 4 * $PostgreSQL::Test::Utils::timeout_default;
Should we bump the timeout like this for all systems? I interpreted Noah's
comment such that it should be possible for slower systems to override, not
that it should be extended everywhere, but I might have missed something.
--
Daniel Gustafsson
From | Date | Subject | |
---|---|---|---|
Next Message | vignesh C | 2023-09-29 10:19:54 | Re: Testing autovacuum wraparound (including failsafe) |
Previous Message | Daniel Gustafsson | 2023-09-29 10:15:30 | Re: On login trigger: take three |