| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Richard Guo <guofenglinux(at)gmail(dot)com>, Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Remove a unused argument from qual_is_pushdown_safe |
| Date: | 2022-11-28 14:31:33 |
| Message-ID: | 8CA0AAC5-688F-4189-BDA0-B684BBDC29BA@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 28 Nov 2022, at 15:15, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> My viewpoint is that this change is misguided. Even if the current
> coding of qual_is_pushdown_safe doesn't happen to reference the
> subquery, it might need to in future.
If I understand the code correctly the variable has some value in terms of
"documenting the code" (for lack of better terminology), and I would assume
virtually every modern compiler to figure out it's not needed.
--
Daniel Gustafsson https://vmware.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2022-11-28 15:27:56 | Bug in wait time when waiting on nested subtransaction |
| Previous Message | Tom Lane | 2022-11-28 14:15:30 | Re: Remove a unused argument from qual_is_pushdown_safe |