Re: BUG #2917: spi_prepare doesn't accept typename aliases

From: Jim Nasby <decibel(at)decibel(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: BUG #2917: spi_prepare doesn't accept typename aliases
Date: 2007-01-26 21:26:40
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Jan 26, 2007, at 9:31 AM, Tom Lane wrote:
> If you wanted to be a bit more ambitious maybe you could change the
> fact
> that this code is throwing away typmod, which means that declarations
> like "varchar(32)" would fail to work as expected. Perhaps it
> should be
> fixed to save the typmods alongside the typioparams and then pass them
> to InputFunctionCall instead of passing -1. On the other hand, we
> don't
> currently enforce typmod for any function input or result
> arguments, so
> maybe it's consistent that spi_prepare arguments ignore typmods too.
> Thoughts?

I'd like to see us move towards supporting that; both for function
parameters/results as well as inside functions. It'd be nice if both
cases got fixed at once, but IMHO fixing only one now would be better
than fixing none.
Jim Nasby jim(at)nasby(dot)net
EnterpriseDB 512.569.9461 (cell)

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Jim Nasby 2007-01-26 21:39:35 Re: Proposal: Change of pg_trigger.tg_enabled and adding
Previous Message Tom Lane 2007-01-26 21:18:44 Re: pg_restore exclude schema from being droped option