Re: get rid of Pointer type, mostly

From: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
To: David Geier <geidav(dot)pg(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: get rid of Pointer type, mostly
Date: 2025-12-08 10:53:15
Message-ID: 8B037F29-163E-4446-BA94-7553C9ECA0F1@gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Dec 8, 2025, at 18:25, David Geier <geidav(dot)pg(at)gmail(dot)com> wrote:
>
> Hi Peter,
>> I went with your proposal of GinExtraPointer. See attached patch. It's
>> based on the series of patches from Peter's initial mail. I've included
>> the removal of the Pointer typedef in the same patch.
>
> It seems to me that we reached agreement. Are you planning to still
> apply these patches?
>

Basically I am not against this patch, as 756a43689324b473ee07549a6eb7a53a203df5ad has done similar changes.

What I want to understand is that why do we delete Pointer and add GinExtraPointer?

```
-/*
- * Pointer
- * Variable holding address of any memory resident object.
- * (obsolescent; use void * or char *)
- */
-typedef void *Pointer;
```

And
```
+typedef void *GinExtraPointer;
```

They both are underlying “void *”. Are we expecting to improve code readability? More specific maybe?

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Chao Li 2025-12-08 11:10:58 Remove unneccessary memory initialization in planner.c
Previous Message Jelte Fennema-Nio 2025-12-08 10:53:02 Re: Safer hash table initialization macro