| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Pgsql Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Call perror on popen failure |
| Date: | 2024-03-08 10:05:01 |
| Message-ID: | 89B00F63-40F7-4D82-8353-DC9CABBAC1D1@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
If popen fails in pipe_read_line we invoke perror for the error message, and
pipe_read_line is in turn called by find_other_exec which is used in both
frontend and backend code. This is an old codepath, and it seems like it ought
to be replaced with the more common logging tools we now have like in the
attached diff (which also makes the error translated as opposed to now). Any
objections to removing this last perror() call?
--
Daniel Gustafsson
| Attachment | Content-Type | Size |
|---|---|---|
| no_perror.diff | application/octet-stream | 392 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2024-03-08 10:06:30 | Re: Add new error_action COPY ON_ERROR "log" |
| Previous Message | Andrey M. Borodin | 2024-03-08 10:01:09 | Re: speed up a logical replica setup |