| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Alexey Bashtanov <bashtanov(at)imap(dot)cc>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: log bind parameter values on error |
| Date: | 2019-01-03 11:56:58 |
| Message-ID: | 896ac2ed-7735-1f24-d877-3249b38bb6fe@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 02/01/2019 23:53, Alexey Bashtanov wrote:
>> In fact, maybe don't use the Portal structure at all and just store the
>> saved textualized values inside postgres.c in a static variable.
>
> Unlike SQL, parameters may spend much more memory, so I'd have them
> in portal memory context to make sure the memory is released earlier
> rather than later.
Having them in the portal structure is different from having it in the
portal memory context. Although there is perhaps value in keeping them
together.
> Do you think it would be acceptable to leave them cached in parameters
> structure?
Let's see how it looks.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Surafel Temesgen | 2019-01-03 12:00:29 | Re: FETCH FIRST clause PERCENT option |
| Previous Message | Nikolay Shaplov | 2019-01-03 11:53:04 | Re: Using vim for developing porstres wiki article |