Re: Trivial libpq refactoring patch (was: Re: Another review of URI for libpq, v7 submission)

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alex Shulgin <ash(at)commandprompt(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Trivial libpq refactoring patch (was: Re: Another review of URI for libpq, v7 submission)
Date: 2012-03-22 16:10:15
Message-ID: 8963.1332432615@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Alex Shulgin <ash(at)commandprompt(dot)com> writes:
> While working on this fix I've figured out that I need my
> conninfo_uri_parse to support use_defaults parameter, like
> conninfo(_array)_parse functions do.

> The problem is that the block of code which does the defaults handling
> is duplicated in both of the above functions. What I'd like to do is
> extract it into a separate function to call. What I wouldn't like is
> bloating the original URI patch with this unrelated change.

Applied with minor adjustments --- notably, I thought
conninfo_add_defaults was a better name for the function.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kevin Grittner 2012-03-22 16:38:17 Re: Gsoc2012 Idea --- Social Network database schema
Previous Message Robert Haas 2012-03-22 15:16:05 Re: HOT updates & REDIRECT line pointers