| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Joshua Brindle <joshua(dot)brindle(at)crunchydata(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Joe Conway <joe(at)crunchydata(dot)com> |
| Subject: | Re: Granting SET and ALTER SYSTE privileges for GUCs |
| Date: | 2022-03-28 19:14:04 |
| Message-ID: | 895385.1648494844@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com> writes:
> On Mar 28, 2022, at 11:31 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> I think we probably have to trash the core-regression-tests part of
>> the patch altogether and instead use a TAP test for whatever testing
>> we want to do. It might be all right to test SET privileges without
>> testing ALTER SYSTEM, but I'm not sure there's much point in that.
> How about putting them under src/test/modules/unsafe_tests ?
Ah, that could work; I'd forgotten about that subdirectory.
It'd still be a good idea if they didn't fail when run twice in a row.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2022-03-28 19:16:55 | Re: Accommodate startup process in a separate ProcState array slot instead of in MaxBackends slots. |
| Previous Message | Tom Lane | 2022-03-28 19:11:15 | Re: Granting SET and ALTER SYSTE privileges for GUCs |