Re: pg_receivewal and SIGTERM

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
Cc: Christoph Berg <myon(at)debian(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pg_receivewal and SIGTERM
Date: 2022-08-16 11:43:31
Message-ID: 894AEB23-270C-4058-BB31-B5B46CAF7C12@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 16 Aug 2022, at 13:40, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
>
> On Tue, Aug 16, 2022 at 5:06 PM Christoph Berg <myon(at)debian(dot)org> wrote:

>> I went with sigexit_handler since pg_recvlogical has also a
>> sighup_handler and "sig_handler" would be confusing there.
>
> Can we move these signal handlers to streamutil.h/.c so that both
> pg_receivewal and pg_recvlogical can make use of it avoiding duplicate
> code?

In general that's a good idea, but they are so trivial that I don't really see
much point in doing that in this particular case.

--
Daniel Gustafsson https://vmware.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Christoph Berg 2022-08-16 11:44:52 Re: pg_receivewal and SIGTERM
Previous Message Bharath Rupireddy 2022-08-16 11:40:54 Re: pg_receivewal and SIGTERM