Re: PATCH: Batch/pipelining support for libpq

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Vaishnavi Prabakaran <vaishnaviprabakaran(at)gmail(dot)com>
Cc: Craig Ringer <craig(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Daniel Verite <daniel(at)manitou-mail(dot)org>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, David Steele <david(at)pgmasters(dot)net>, "Prabakaran, Vaishnavi" <VaishnaviP(at)fast(dot)au(dot)fujitsu(dot)com>, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>, Dmitry Igrishin <dmitigr(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Manuel Kniep <m(dot)kniep(at)web(dot)de>, "fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp" <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>, "Iwata, Aya" <iwata(dot)aya(at)jp(dot)fujitsu(dot)com>
Subject: Re: PATCH: Batch/pipelining support for libpq
Date: 2017-10-02 09:31:07
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

> On 13 Sep 2017, at 07:44, Vaishnavi Prabakaran <vaishnaviprabakaran(at)gmail(dot)com> wrote:
> On Wed, Sep 13, 2017 at 3:33 PM, Craig Ringer <craig(at)2ndquadrant(dot)com <mailto:craig(at)2ndquadrant(dot)com>> wrote:
> I really do not like calling it "commit" as that conflates with a database commit.
> A batch can embed multiple BEGINs and COMMITs. It's entirely possible for an earlier part of the batch to succeed and commit, then a later part to fail, if that's the case. So that name is IMO wrong.
> Ok, SendQueue seems ok to me as well. Will change it in next version.
> +"a"?
> Hmm, Can you explain the question please. I don't understand.
> s/of new query/of a new query/
> Thanks for explaining. Will change this too in next version.

Based on the discussions in this thread, and that a new version hasn’t been
submitted, I’m marking this Returned with Feedback. Please re-submit the new
version in an upcoming commitfest when ready.

cheers ./daniel

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2017-10-02 09:36:27 Re: Patch: Write Amplification Reduction Method (WARM)
Previous Message Daniel Gustafsson 2017-10-02 08:54:34 Re: Parallel COPY FROM execution