| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | James Coleman <jtc331(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, David Steele <david(at)pgmasters(dot)net>, David Zhang <david(dot)zhang(at)highgo(dot)ca>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Nicer error when connecting to standby with hot_standby=off |
| Date: | 2021-03-23 16:34:01 |
| Message-ID: | 890750.1616517241@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> However, for this one
> + case CAC_NOTCONSISTENT:
> + if (EnableHotStandby)
> + ereport(FATAL,
> + (errcode(ERRCODE_CANNOT_CONNECT_NOW),
> + errmsg("the database system is not accepting connections"),
> + errdetail("Consistent recovery state has not been yet reached.")));
> Maybe it makes sense to say "... is not accepting connections *yet*".
+1, but I think "... is not yet accepting connections" is slightly
better style.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2021-03-23 16:46:40 | Re: making update/delete of inheritance trees scale better |
| Previous Message | Pantelis Theodosiou | 2021-03-23 16:33:37 | Re: [PATCH] Allow multiple recursive self-references |