Skip site navigation (1) Skip section navigation (2)

Re: PITR Error Message assistance

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Simon Riggs <simon(at)2ndquadrant(dot)com>, pgsql-admin(at)postgresql(dot)org
Subject: Re: PITR Error Message assistance
Date: 2004-06-30 14:58:44
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-adminpgsql-hackers
Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> Simon Riggs wrote:
>> + elog(WARNING, "could not set notify for archiver to read log file
>> %u, segment %u",

> Reason? (disk full, network down, leap year?)

> I think elog() calls don't get translated.  You should always use 
> ereport.  Tom would know more about the distinction.

elog is deprecated except for debugging or "can't-happen" messages.
Anything user-facing ought to be reported with ereport.  In this case
elog might be okay --- it's not clear to me from this snippet whether
the condition is one a user would be likely to see.

There's plenty of detail about all this in chapter 45 of the docs:
and I think most of Peter's comments trace directly to items in the
message style guide there.

			regards, tom lane

In response to


pgsql-hackers by date

Next:From: Tom LaneDate: 2004-06-30 15:04:37
Subject: Re: Compile Failue on win32 - pipe.c using ereport
Previous:From: Christopher Kings-LynneDate: 2004-06-30 14:45:39
Subject: Win32 version question

pgsql-admin by date

Next:From: Tom LaneDate: 2004-06-30 15:07:00
Subject: Re: grant execute on many functions
Previous:From: Tuttle, GeneDate: 2004-06-30 13:58:57
Subject: PL/pgSQL

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group