Re: REPACK enhancements

Antonin Houska <ah(at)cybertec(dot)at> wrote:

> Antonin Houska <ah(at)cybertec(dot)at> wrote:
>
> The next version is attached.
>
> > Manu <manuelreyesbravo(at)gmail(dot)com> wrote:
> >
> > > 3. 0008: assertion failure in compute_new_xmax_infomask()
> > >
> > > TRAP: failed Assert("TransactionIdIsCurrentTransactionId(add_to_xmax) || !TransactionIdIsValid(GetTopTransactionIdIfAny())"), File: "heapam.c", Line: 5564
> > >
> > > It fails in the replay after AccessExclusiveLock, called from
> > > rebuild_relation_finish_concurrent(), in heap_update() of a replayed
> > > UPDATE. So REPACK already has an XID of its own at that point.
> >
> > I don't know at the moment when the XID could get assigned. I need to do some
> > investigation.
>
> This is still on my TODO list, I'm afraid I couldn't reproduce this problem yet.

For now I commented the assertion out and added a comment on possible
solutions.

Besides that, I rebased the patch and fixed splitting into diffs (some changes
done in v04-0008 belonged to other diffs of v04 as well). Also, 0001 is now a
new diff, removing an unused function argument.

--
Antonin Houska
Web: https://www.cybertec-postgresql.com