Re: pgsql: Avoid creation of the free space map for small heap relations.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>, Amit Kapila <akapila(at)postgresql(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, John Naylor <john(dot)naylor(at)2ndquadrant(dot)com>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Avoid creation of the free space map for small heap relations.
Date: 2019-01-28 05:48:51
Message-ID: 8872.1548654531@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> writes:
> Yes, so this could be the cause of the problem. I think we need to
> change the tests added by the patch such that they don't rely on
> vacuum to remove dead-row versions? Do you or anybody else see any
> better way to fix this?

To be blunt, this patch needs to be reverted immediately. The failures
that are showing up are not just "the fsm test is not portable" problems.
See for example

https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=mantid&dt=2019-01-28%2005%3A07%3A06

https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=dromedary&dt=2019-01-28%2003%3A07%3A39

https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=lapwing&dt=2019-01-28%2003%3A20%3A02

I don't know what the common thread is here, but you don't get to leave
the buildfarm broken this badly while you figure it out.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Amit Kapila 2019-01-28 05:56:11 Re: pgsql: Avoid creation of the free space map for small heap relations.
Previous Message Andrew Gierth 2019-01-28 05:40:47 Re: pgsql: Avoid creation of the free space map for small heap relations.

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2019-01-28 05:56:11 Re: pgsql: Avoid creation of the free space map for small heap relations.
Previous Message Andrew Gierth 2019-01-28 05:40:47 Re: pgsql: Avoid creation of the free space map for small heap relations.