| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Nikolay Shaplov <dhyan(at)nataraj(dot)su>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Nikita Glukhov <n(dot)gluhov(at)postgrespro(dot)ru>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH][PROPOSAL] Add enum releation option type |
| Date: | 2018-11-01 15:10:14 |
| Message-ID: | 8871.1541085014@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Wed, Mar 7, 2018 at 10:23 AM Nikolay Shaplov <dhyan(at)nataraj(dot)su> wrote:
>>> I see you lost the Oxford comma:
>>>
>>> -DETAIL: Valid values are "on", "off", and "auto".
>>> +DETAIL: Valid values are "auto", "on" and "off".
>>>
>>> Please put these back.
>> Actually that's me who have lost it. The code with oxford comma would be a
>> bit more complicated. We should put such coma when we have 3+ items and do not
>> put it when we have 2.
>>
>> Does it worth it?
> In my opinion, it is worth it.
Uh ... I've not been paying attention to this thread, but this exchange
seems to be about somebody constructing a message like that piece-by-piece
in code. This has got to be a complete failure from the translatability
standpoint. See
https://www.postgresql.org/docs/devel/static/nls-programmer.html#NLS-GUIDELINES
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Karsten Hilbert | 2018-11-01 15:11:33 | Re: backend crash on DELETE, reproducible locally |
| Previous Message | Daniel Gustafsson | 2018-11-01 15:01:22 | Re: PG vs macOS Mojave |