| From: | Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> |
|---|---|
| To: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Donald Dong <xdong(at)csumb(dot)edu>, Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Chapman Flack <chap(at)anastigmatix(dot)net> |
| Subject: | Re: Ryu floating point output patch |
| Date: | 2019-02-17 23:42:08 |
| Message-ID: | 87zhquhto6.fsf@news-spur.riddles.org.uk |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>>>>> "Andrew" == Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> writes:
Tom> I think we have to document it, but it can be fairly terse perhaps.
Tom> Use the specified value of extra_float_digits when dumping
Tom> floating-point data, rather than pg_dump's default.
Tom> I don't think we need to go into detail about when/why you might
Tom> want to use it; I can see people thinking of their own reasons.
>> It should probably at least say that (a) the default is to dump with the
>> maximum available precision, and at least hint at (b) that ordinary use
>> doesn't require the option. We shouldn't mislead people into thinking
>> they need it when they don't.
Andrew> Would you like to reformulate this, then?
How about:
Use the specified value of extra_float_digits when dumping
floating-point data, instead of the maximum available precision.
Routine dumps made for backup purposes should not use this option.
--
Andrew (irc:RhodiumToad)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2019-02-17 23:49:04 | Re: Ryu floating point output patch |
| Previous Message | Michael Paquier | 2019-02-17 23:38:20 | Re: BUG #15572: Misleading message reported by "Drop function operation" on DB with functions having same name |