Re: Speedup usages of pg_*toa() functions

From: Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>
To: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
Cc: David Rowley <dgrowleyml(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>
Subject: Re: Speedup usages of pg_*toa() functions
Date: 2020-06-09 20:42:45
Message-ID: 87zh9c55up.fsf@news-spur.riddles.org.uk
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

>>>>> "Ranier" == Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> writes:

Ranier> So I would change, just the initialization (var uvalue), even though it is
Ranier> irrelevant.

Ranier> int
Ranier> pg_lltoa(int64 value, char *a)
Ranier> {
Ranier> int len = 0;
Ranier> uint64 uvalue;

Ranier> if (value < 0)
Ranier> {
Ranier> uvalue = (uint64) 0 - uvalue;

Use of uninitialized variable.

--
Andrew (irc:RhodiumToad)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2020-06-09 21:04:42 Re: global barrier & atomics in signal handlers (Re: Atomic operations within spinlocks)
Previous Message Ranier Vilela 2020-06-09 19:51:58 Re: Speedup usages of pg_*toa() functions