Re: Better shared data structure management and resizable shared data structures

From: Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>
To: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Cc: Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, chaturvedipalak1911(at)gmail(dot)com
Subject: Re: Better shared data structure management and resizable shared data structures
Date: 2026-04-07 12:24:28
Message-ID: 87y0iz2c1v.fsf@wibble.ilmari.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Heikki Linnakangas <hlinnaka(at)iki(dot)fi> writes:

> Those are now committed, and here's a new version rebased over those
> changes.

I noticed this bit during my habitual morning skim of new commits:

> diff --git a/src/backend/utils/misc/injection_point.c b/src/backend/utils/misc/injection_point.c
> index c06b0e9b800..9981d6e212f 100644
> --- a/src/backend/utils/misc/injection_point.c
> +++ b/src/backend/utils/misc/injection_point.c
> @@ -17,6 +17,7 @@
> */
> #include "postgres.h"
>
> +#include "storage/subsystems.h"
> #include "utils/injection_point.h"
>
> #ifdef USE_INJECTION_POINTS
> @@ -109,6 +110,11 @@ typedef struct InjectionPointCacheEntry
>
> static HTAB *InjectionPointCache = NULL;
>
> +#ifdef USE_INJECTION_POINTS
> +static void InjectionPointShmemRequest(void *arg);
> +static void InjectionPointShmemInit(void *arg);
> +#endif
> +

This is already inside an `#ifdef USE_INJECTION_POINTS` guard (in fact
visible at the end of the previous diff hunk), no need for another one.

- ilmari

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Hayato Kuroda (Fujitsu) 2026-04-07 12:32:32 RE: Adding REPACK [concurrently]
Previous Message Antonin Houska 2026-04-07 12:17:57 Re: Adding REPACK [concurrently]