Re: appendStringInfoString() micro-opt

From: Neil Conway <neilc(at)samurai(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: appendStringInfoString() micro-opt
Date: 2004-01-25 23:36:08
Message-ID: 87wu7f8utz.fsf@mailbox.samurai.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
> I'm not objecting to your doing it, exactly, just suggesting that
> there are better things to spend your time on.

Heh, probably true :-)

I'll put this on the back-burner for now, and repost a complete patch
later if I get around to it.

> This I would object to, since it creates a risk of failure if anyone
> is incautious enough to write a non-constant argument to
> appendStringInfoString.

Agreed.

(Semi-OT note: allowing the user to extend the compiler to enforce
rules like this is a cool idea: http://metacomp.stanford.edu/)

-Neil

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Bill Moran 2004-01-26 00:00:02 [update] Re: Patch to bring \copy syntax more in line with SQL copy
Previous Message Neil Conway 2004-01-25 23:27:32 Re: next draft of list rewrite