Re: Two aesthetic bugs in the 1-byte packed varlena code

From: Gregory Stark <stark(at)enterprisedb(dot)com>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "pgsql-patches" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Two aesthetic bugs in the 1-byte packed varlena code
Date: 2007-06-12 14:18:22
Message-ID: 87wsy9fe8h.fsf@oxford.xeocode.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

"Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:

> Gregory Stark <stark(at)enterprisedb(dot)com> writes:
>> Why do we even have those fields in the structs if they're unsafe to use?
>
> 1. genbki.sh

But genbki.sh wouldn't care if we #if 0 around the unsafe ones would it?

> 2. As you note, they're not always unsafe to use.

Well, it seems like it would be nice to mark which ones are and aren't unsafe
rather than have them all be there waiting to trip people up.

--
Gregory Stark
EnterpriseDB http://www.enterprisedb.com

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Satoshi Nagayasu 2007-06-12 14:51:32 trace_checkpoint parameter patch
Previous Message Tom Lane 2007-06-12 14:11:39 Re: Two aesthetic bugs in the 1-byte packed varlena code