Re: assert in nested SQL procedure call in current HEAD

From: Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: assert in nested SQL procedure call in current HEAD
Date: 2018-06-12 16:47:35
Message-ID: 87wov4rm72.fsf@news-spur.riddles.org.uk
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

>>>>> "Peter" == Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:

>> Did you miss the fact that the issue only occurs when the top-level
>> procedure does a rollback? The problem is not with nested calls, but
>> rather with the fact that commit or rollback is leaving
>> ActiveSnapshot unset, which is (as Tom pointed out at the linked
>> post) not the expected condition inside PL code.

Peter> We need that so that we can run things like SET TRANSACTION
Peter> ISOLATION.

While testing this, I ran into another semi-related issue:
shmem_exit_inprogress isn't ever being cleared in the postmaster, which
means that if you ever have a crash-restart, any attempt to do a
rollback in a procedure will then crash or get some other form of
corruption again every time until you manually restart the cluster.

--
Andrew (irc:RhodiumToad)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2018-06-12 16:54:41 Re: why partition pruning doesn't work?
Previous Message Robert Haas 2018-06-12 16:40:28 Re: why partition pruning doesn't work?