Re: psql and readline comments

From: Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Дилян Палаузов <dpa-postgres(at)aegee(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: psql and readline comments
Date: 2019-01-26 04:41:17
Message-ID: 87womsjbpq.fsf@news-spur.riddles.org.uk
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

>>>>> "Bruce" == Bruce Momjian <bruce(at)momjian(dot)us> writes:

Bruce> Agreed. I am not sure how someone would conditionally bind M-#
Bruce> to -- _only_ in psql,

By doing this in .inputrc:

$if psql
set comment-begin "--"
$endif

(observe that we set rl_readline_name in order to allow this)

But that shouldn't necessarily stop us doing the setting in psql by
default - it just needs to be verified that it does compile against the
libedit versions people are actually using, and not break anything. (On
the libedit on my system, rl_variable_bind ends up trying to bind the
variable as a _key_, and I have no idea what effect that would have if
any. Note that libedit does not seem to bind M-# by default.)

--
Andrew (irc:RhodiumToad)

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message CNG L 2019-01-28 02:21:11 Why PG_SETMASK() change errno to 0 when there is an elog() call before or after it? Is it a bug?
Previous Message Bruce Momjian 2019-01-26 00:18:01 Re: psql and readline comments